Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates.md docs: Document string literal format #2256

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

ilyagr
Copy link
Collaborator

@ilyagr ilyagr commented Sep 14, 2023

We are a little weird about which string escapes we support, and we don't support raw strings. I thought this might be worth documenting.

Inspired by #2251

@ilyagr ilyagr marked this pull request as ready for review September 14, 2023 23:52
docs/templates.md Outdated Show resolved Hide resolved
@ilyagr
Copy link
Collaborator Author

ilyagr commented Sep 15, 2023

Thanks Martin!

@yuja, could you also glance at this to make sure I didn't miss some detail?

We are a little weird about which string escapes we support, and we don't
support raw strings.  I thought this might be worth documenting.

Inspired by jj-vcs#2251
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/templates.md Show resolved Hide resolved
@ilyagr ilyagr merged commit c45216e into jj-vcs:main Sep 16, 2023
15 checks passed
@ilyagr ilyagr deleted the stringlit branch September 16, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants